feat: unquoted escaping added#72
Open
sirkon wants to merge 6 commits intonapi-rs:mainfrom
Open
Conversation
sirkon
force-pushed
the
main
branch
6 times, most recently
from
551e7ad to
2415e23
Compare
- format_raw is unsafe everywhere - dropped unused variables from format_unquoted everywhere - fixed "misspell" when avx/sse/neon stuff could call v128's format_raw - checked every hardware I could (except avx512 I have no access too)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a case where I construct keys with concatenation. Need to concatenate in a standalone buffer with the current API, meaning excessive copying. The proposed "unquoted" API solves this issue.